If the user choose to check that option, this should overwrite old mask option in the preset with the current mask option. When one click on a preset + CTRL key pressed, darktable should RESET current mask optionsįollowing option 2, the user wants to modify the preset he loaded and this preset contain mask option, the box 'include/save/replace mask options' is checked by default but if the current mask option has been modified or the user loaded the preset with CTRL pressed, the box should be unchecked.When one click on a preset with mask options, darktable should replace current mask options with saved mask options in preset.When one click on a preset without mask options, darktable should NOT reset current mask options.The user can check a box 'include (or save/replace) mask options' in the saving preset menu. When one click on a preset + CTRL key pressed, darktable should NOT erase current mask options.When one click on a preset, darktable should erase current mask options.I wanted to open a FR but this topic already exist. I was trying to test different preset on a module with mask but, of cours, each time I load a preset, darktable resets all mask option 😒. For most things this shouldn't be a problem unless there's a preset that has same exact module settings, but one is with blending and other is without.Īnd one last 'problem' (but just in conceptual sense) is how best to differentiate between preset with no blending settins and one with ones that explicitly have disabled masking (so apply globally) With separate masking we'd have to think how to define 'active preset'? This is important because of 2 things: current preset is highlighted in presets menu and actions like updating/deleting/editing 'current preset'. I see no use for 'just blending' with 'whatever' module settings.Ĭurrently the notion of 'active preset' has meaning: current settings and masking match 1:1 with preset, therefore preset is active. With separate masking I see 2 classes of presets: module settings + blending and just module settings.

This makes sense for most of the modules, but some things like eg contrast equalizer, denoising modules or the module in #7255 would be great candidates for separate masking. Internally a preset is set of all the module settings and all the blending options. That's actually a great idea! There are couple interactions with presets in modules to think about so we can gather what would be the best workflow.

Best darktable presets